FS-59 Add pytest bdd #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mic-smith
force-pushed
the
FS-59/add-pytest-bdd
branch
from
de01657 to
4acaef3
Compare
mic-smith
force-pushed
the
FS-59/add-pytest-bdd
branch
from
4acaef3 to
0dde4a8
Compare
|
|
||
| tolerance = Decimal("0.01") | ||
| is_equal = abs(expected_value - actual_value) <= tolerance | ||
|
|
There was a problem hiding this comment.
We may not actually need this decimal stuff. I originally thought we had an issue with types before finding out it was the closed loop error stuff. Don't think it would hurt to keep it in though!
There was a problem hiding this comment.
Yes, I don't think it's currently used, as it would only apply when just a numeric value is returned.
mnyamunda-scottlogic
approved these changes
Oct 30, 2024
evpearce
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Incorporates pytest-bdd and is based on the changes in WaitThatShouldntWork/Infer@main...feature/bdd-test
Uses LangChain evaluators to check for correctness in the case of none contains matches,
Changelog